Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to latest @typescript-eslint #63

Merged
merged 2 commits into from
Feb 9, 2020
Merged

Conversation

iamturns
Copy link
Owner

@iamturns iamturns commented Feb 9, 2020

Includes support for latest TypeScript version.

Fixes #53.

BREAKING CHANGE 1

New rules require type information from your tsconfig.json file.

You must set parserOptions.project within your ESLint config file.

Example ESLint config:

module.exports = {
  extends: ['airbnb-typescript'],
  parserOptions: {
    project: './tsconfig.json'
  }
}

BREAKING CHANGE 2

You must upgrade your local dependency of @typescript-eslint/eslint-plugin to 2.19.0.

Example command: npm install @typescript-eslint/eslint-plugin@^2.19.0 --save-dev.

@iamturns iamturns merged commit faf7a74 into master Feb 9, 2020
@iamturns iamturns deleted the update-ts-eslint-deps branch February 9, 2020 00:12
@iamturns
Copy link
Owner Author

iamturns commented Feb 9, 2020

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viT-1
Copy link

viT-1 commented Feb 12, 2020

Why with 7.0.0 I should include all dev scripts (package.json, etc) (which I want to lint) into tsconfig?

My lint command in package.json scripts:
tsc --project ./src/tsconfig.dev.json --noEmit && eslint **/*.{ts,json,js} *.* .*.js

#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsupported typescript version
2 participants