From d65838c49c17231af2456f3ccf7689c80a124c3c Mon Sep 17 00:00:00 2001 From: "Jeremy W. Sherman" Date: Fri, 11 Dec 2015 15:14:51 -0500 Subject: [PATCH] Hoist common username to |expected_reviewer| --- spec/lita/handlers/reviewme_spec.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/spec/lita/handlers/reviewme_spec.rb b/spec/lita/handlers/reviewme_spec.rb index ca3fc6b..ae2b61a 100644 --- a/spec/lita/handlers/reviewme_spec.rb +++ b/spec/lita/handlers/reviewme_spec.rb @@ -78,14 +78,16 @@ it "skips assigning to the GitHub PR owner" do expect_any_instance_of(Octokit::Client).to receive(:pull_request) .with(repo, id).and_return(pr) + + expected_reviewer = 'NOT THE PR OWNER' expect_any_instance_of(Octokit::Client).to receive(:add_comment) - .with(repo, id, ":eyes: @iamvery") + .with(repo, id, ":eyes: @#{expected_reviewer}") send_command("add #{pr.user.login} to reviews") - send_command("add iamvery to reviews") + send_command("add #{expected_reviewer} to reviews") send_command("review https://github.com/#{repo}/pull/#{id}") - expect(reply).to eq("iamvery should be on it...") + expect(reply).to eq("#{expected_reviewer} should be on it...") end it "handles errors gracefully" do