Correct meaning of "actual" and "expected" #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's actually a bug in the matcher implementation. These names along with some additional information should bring it to light...
This serves to highlight the bug mentioned in the previous commit. Fakes should be able to have _additional_ behavior, however this test now fails. That is because I got the order of things reversed in the matcher implementation.
It's been really hard to get my head around this.. the "actual" is the _VALUE BEING TESTED_. The "expected" is the _VALUE BE TESTED AGAINST_. I suppose it's hard to grok, because the "actual" is the value given to `expect()`...
iamvery
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so hard to keep straight in my head... 😅