Ian Bicking ianb

Organizations

@mozilla @Pandacodium
@ianb
Use contentScriptOptions for shooter-interactive-worker.js
@ianb
Text clips have large leading margin
@ianb
deleter scrolls with clip
ianb opened pull request mozilla-services/pageshot#337
@ianb
r?fzzzy Fix text selection
3 commits with 77 additions and 13 deletions
@ianb
ianb opened pull request glennjones/microformat-shiv#18
@ianb
Fix undeclared variable
1 commit with 1 addition and 1 deletion
@ianb
ianb commented on pull request mozilla-services/pageshot#336
@ianb

Just those two notes, if you want to push after them

ianb commented on pull request mozilla-services/pageshot#336
@ianb

should probably do encodeURIComponent(clip.id), on principle.

ianb commented on pull request mozilla-services/pageshot#336
@ianb

We should be doing some assertion here, I think that m.origin == location.origin (i.e., the message comes from our site)

@ianb
Include padding around autoselect
@ianb
ianb merged pull request mozilla-services/pageshot#332
@ianb
r? ianbicking Detail ui refresh
2 commits with 89 additions and 34 deletions
ianb commented on pull request mozilla-services/pageshot#332
@ianb

Just FYI, eventually we'll probably use shot.title which will pick from the best title (maybe shot.userTitle || shot.ogTitle || shot.docTitle)

@ianb
Clip delete in panel
ianb opened pull request mozilla-services/pageshot#331
@ianb
r?fzzzy Panel delete
3 commits with 65 additions and 7 deletions
@ianb
ianb merged pull request mozilla-services/pageshot#330
@ianb
r? ianbicking Show all clips
2 commits with 11 additions and 5 deletions
ianb commented on pull request mozilla-services/pageshot#327
@ianb

It looks like this still fails with an import error? Message: Moduleshooter.jsis not found at resource://gre/modules/commonjs/shooter.js

@ianb
  • @ianb 1e0a9e1
    Notify IRC of travis builds, and try again with the build script path…
@ianb
  • @ianb 73f450c
    Let's try to do jpm test from a different directory
@ianb
ianb closed pull request mozilla-services/pageshot#326
@ianb
Making some changes required to switch from cfx to jpm
ianb commented on pull request mozilla-services/pageshot#326
@ianb

Merged, though somehow through bad command-fu I merged it in a way that doesn't show this commit as closed, but it is merged.

ianb closed pull request mozilla-services/pageshot#325
@ianb
adding a travis button to the readme
ianb commented on pull request mozilla-services/pageshot#325
@ianb

I just put a badge in myself shortly before this PR – but now I'm unsure what I have to do to get Travis to actually run (I haven't used Travis bef…