Skip to content
This repository was archived by the owner on Jan 5, 2021. It is now read-only.
This repository was archived by the owner on Jan 5, 2021. It is now read-only.

StateChange subclass not part of upstream pysignal project #205

@knight-of-ni

Description

@knight-of-ni

This is part of the open package review on redhat, to get ouimeaux added to the offical Fedora repos. https://bugzilla.redhat.com/show_bug.cgi?id=1839242

Follow along with me here...

During the review, it was noticed that pysignals was bundled with ouimeaux. I have to unbundle it into it's own package. This was done and a request for a new pysignals package was created:
https://bugzilla.redhat.com/show_bug.cgi?id=1848049

That has lead to the discovery that the bundled pysignals has a custom subclass StateChange, which is not part of the upstream pysignals project.

This subclass was added in commit d2fc935 .

Technically, I could just patch d2fc935 into the new pysignals rpm package.

However, I think it would be more appropriate to move the subclass definition out of dispatcher.py to somewhere else in ouimeaux project folder. Let me know your thoughts on this. I am not convinced one way or the other at the moment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions