Skip to content
This repository was archived by the owner on Jan 5, 2021. It is now read-only.

replace cElementTree with ElementTree #204

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

knight-of-ni
Copy link
Contributor

@knight-of-ni knight-of-ni commented Jun 16, 2020

fixes #203

This fixes the most immediate need by replacing cElementTree with ElementTree in these files:

ouimeaux/device/api/service.py
ouimeaux/device/maker.py
ouimeaux/device/bridge.py
ouimeaux/subscribe.py

However, a better fix might be to implement a series of try/except, similar to what has already been done here:
https://github.com/iancmcc/ouimeaux/blob/develop/ouimeaux/device/api/xsd/service.py#L27
https://github.com/iancmcc/ouimeaux/blob/develop/ouimeaux/device/api/xsd/device.py#L27

I'll leave that up to the author to decide.

@iancmcc
Copy link
Owner

iancmcc commented Jun 16, 2020

LGTM. I need to go through and clean up those imports to do it centrally, but in the meantime this is perfectly fine.

@iancmcc iancmcc merged commit dc178bc into iancmcc:develop Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cElementTree removed in Python 3.9
2 participants