This repository was archived by the owner on Jan 5, 2021. It is now read-only.
replace cElementTree with ElementTree #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #203
This fixes the most immediate need by replacing cElementTree with ElementTree in these files:
However, a better fix might be to implement a series of try/except, similar to what has already been done here:
https://github.com/iancmcc/ouimeaux/blob/develop/ouimeaux/device/api/xsd/service.py#L27
https://github.com/iancmcc/ouimeaux/blob/develop/ouimeaux/device/api/xsd/device.py#L27
I'll leave that up to the author to decide.