This repository was archived by the owner on Jan 5, 2021. It is now read-only.
move StateChange subclass to signals.py #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing. This PR should no longer be needed since the StateChange subclass has been merged into the pysignals upstream project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #205
This is one way to resolve the packaging dilemma described in #205.
This PR attempts to strike a compromise by leaving the bundled pysignals library in place (done by design as as result of #32), while at the same time making it easier for a packager to unbundle pysignals in favor of a pysignals package from the target distro.
Feedback is welcome here.