Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: Add optional visual screen privacy safeguard for private data. #164
This adds a simple checkbox form element, to enable the user to visually hide the private info on the page.
Consider a scenario where a more technical person is helping someone verify their 24 word recovery phrase for their hardware wallet. The technical person would typically need to help verify the generated hash addresses, to make sure that the 24 words were correct.
In this scenario, ideally, the owner of the hardware wallet should be able to hide the recovery phrase and qr code from view. That way, the assistant can look at the bip39 page to verify the non-private hash addresses without seeing the hardware wallet owner's private info.
At this point, both iancoleman/bip39 master branch and my fork produce these results on my box, which all seem to be due to the test tool's timeout being too short for my local set-up (I am running a laptop with only small graphics capability, so perhaps that is affecting the tests):
I tried a larger
I've attached text files showing the complete logs for the test run on both the original and this fork. The only issues seem to be due to timeouts.
Here's what I did to try to eliminate the timeouts:
It seems that since both master and my fork produce the same test result, my change is orthogonal to any test issues. Those test issues would seem to be a separate topic.
This pull request ended up with conflicts and some changes from the original PR.
I've added the feature in 0b6e351 and is included in the current release 0.3.7
Thanks for the suggestion, I think this is a great feature.