Fix issue 8955 and 5 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really like including a 300KB jar in a 100KB plugin, but we'll go for it... |
|
Apache Commons Lang is a really... common library. One way to reduce the size would be to use proguard. |
|
Yes, I realize that it's common. It doesn't change the fact that it quadrupled the size of the plugin. But I don't care enough to use proguard :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://josm.openstreetmap.de/ticket/8955
#5
NOTE:
Please create lib directory and copy commons-lang3-3.1.jar into this directory.
http://commons.apache.org/proper/commons-lang/download_lang.cgi