Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may have noticed, that the pull tester has gone a little crazy lately ;)
To prevent people getting discouraged, or even angry ( I already heard a
grrr
:( ), this should be fixed ASAP...The problem, IMHO, could be that something happend before a created branch gets deleted (user interrupt ?). So the next attempt to
git checkout -b branchname
will fail and the followinggit merge
will be applied to the staging branch, making it dirty for all subsequent tests.I honestly don't know if that really makes sense, but it happened to me and the results look similar to those produced by fellow @joomla-jenkins lately ;)
To reproduce:
pull 666
, pressCtrl-C
and delete the db entry.git checkout -b pull666
, a message likefatal: git checkout: branch pull666 already exists
will appear and the branch remains on
staging
Does that make sense ?
Next bug: On your current head I get a fatal error saying that the class JGithubRefs could not be found.. it seems to be missing in the repo..
Next idea: I believe that it would be helpfull to inform the "fellow contributors" about the details of the errors reported. It seems quite hard for a lot of people to setup phpUnit and the CodeSniffer...
So I am playing with some static GitHub pages to display the error details. Maybe a link to an (official) error detail page could be included in the pull request comment when reporting the errors.
It may look something like this: http://elkuku.github.com/pulltester/329.html
and even displays funky things: http://elkuku.github.com/pulltester/387.html
and an overview table: http://elkuku.github.com/pulltester/
The styles might need some improvements ;)
I wouldn't offer you the code for merging, as it contains a lot of crap and personal stuff, but you are hereby granted to copy & paste whatever you find usable from here:
https://github.com/elkuku/pulltester/blob/testing1/src/pulltester.php
Thats it for now :)
As always: Excellent work Ian. I really admire your innovative ideas