Skip to content

/ queryparser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function translations replace column names #4

Closed
ianmcook opened this issue Aug 31, 2019 · 1 comment
Closed

Function translations replace column names #4

ianmcook opened this issue Aug 31, 2019 · 1 comment
Labels
bug

Comments

@ianmcook
Copy link
Owner

@ianmcook ianmcook commented Aug 31, 2019

Currently the translate_direct replaces columns with names that match function names.

parse_expression("month = 12", T)
#lubridate::month == 12

To fix this, do not call substitute directly in translate_direct. Instead call a function that calls substitute only on functions (the parent element of a call).
@ianmcook ianmcook added the bug label Aug 31, 2019
ianmcook added a commit that referenced this issue Aug 31, 2019
@ianmcook
Fix direct replacement false positive bug (#4) and test fix
4a0d167
@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Aug 31, 2019

Fixed in 4a0d167
@ianmcook ianmcook closed this Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ianmcook
You can’t perform that action at this time.