Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function show_dplyr() #8

Closed
ianmcook opened this issue Jan 4, 2020 · 4 comments
Closed

Add function show_dplyr() #8

ianmcook opened this issue Jan 4, 2020 · 4 comments
Labels

Comments

@ianmcook
Copy link
Owner

@ianmcook ianmcook commented Jan 4, 2020

Add a function show_dplyr() that prints the resulting dplyr code instead of running it.

ianmcook added a commit that referenced this issue Jan 4, 2020
@ianmcook ianmcook closed this in 7d1c52f Jan 5, 2020
ianmcook added a commit that referenced this issue Jan 5, 2020
@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Jan 5, 2020

The current implementation of show_dplyr() has the following known issue:

  • Inside calls to functions with more than 5 arguments passed to them, all arguments beyond the 5th are truncated in the printed dplyr code. This is caused by truncation logic in rlang:::list_deparse().
@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Jan 17, 2020

I documented the argument truncation behavior and added a test for it in c1aee8c.

@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Jan 17, 2020

I opened an rlang PR to control the truncation behavior r-lib/rlang#897

@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Jan 20, 2020

I made changes to prepare for r-lib/rlang#897 in 77c12a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.