-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readgssi.py #5
Conversation
Add of average background removal and a dewow filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In python3 I get "zip object is not subscriptable" on line 561 in the dewow section. Background removal algorithm is incredible though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed in comments
|
||
|
||
#Dewow filter | ||
signal=zip(*a)[10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change this needs for python3 compatibility is that instead of signal=zip(*a)[10]
this should be signal=list(zip(*a))[10]
Found myself with some free time. Accepting pull request and then pushing requested changes. |
Sorry for the late answer and thanks for the accepting pull request.
I make a break on the script but I already find some AGC function we can
add later on.
Best regards
François-Xavier
2018-08-27 23:08 GMT+02:00 Ian <notifications@github.com>:
… Merged #5 <#5> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AoSO_xEGZWXy9wSYIS9Kd9gwIxG5Y6BMks5uVF-2gaJpZM4V_8RP>
.
--
*François-Xavier SIMON*
Géophysicien
Direction Scientifique et Technique
INRAP - UMR 6249 Chrono-Environnement
Inrap - 9 rue Lavoisier - 25000 Besançon
Tél : 06 33 19 06 35
*https://inrap.academia.edu/FrançoisXavierSimon
<https://inrap.academia.edu/Fran%C3%A7oisXavierSimon>*
www.inrap.fr
Abonnez-vous à la lettre d'information de l'Inrap :
http://www.inrap.fr/newsletter.php
|
Add of average background removal and a dewow filter