Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readgssi.py #5

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Update readgssi.py #5

merged 1 commit into from
Aug 27, 2018

Conversation

fxsimon
Copy link
Contributor

@fxsimon fxsimon commented Aug 16, 2018

Add of average background removal and a dewow filter

Add of average background removal and a dewow filter
Copy link
Owner

@iannesbitt iannesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python3 I get "zip object is not subscriptable" on line 561 in the dewow section. Background removal algorithm is incredible though!

Copy link
Owner

@iannesbitt iannesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed in comments



#Dewow filter
signal=zip(*a)[10]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change this needs for python3 compatibility is that instead of signal=zip(*a)[10] this should be signal=list(zip(*a))[10]

@iannesbitt
Copy link
Owner

Found myself with some free time. Accepting pull request and then pushing requested changes.

@iannesbitt iannesbitt merged commit c958c53 into iannesbitt:master Aug 27, 2018
@fxsimon
Copy link
Contributor Author

fxsimon commented Aug 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants