Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean language input bug, missing chars, eventually freezing #1701

Closed
doortts opened this issue Mar 13, 2018 · 6 comments
Closed

Korean language input bug, missing chars, eventually freezing #1701

doortts opened this issue Mar 13, 2018 · 6 comments

Comments

@doortts
Copy link

doortts commented Mar 13, 2018

Do you want to request a feature or report a bug?

First, I want to say thank you for your awesome editor. I'm a maintainer of project hosting software Yona
We want to change our main editor to slate. But there are problems now. I hope it is resolved.

What's the current behavior?

When I type Korean, if I type more than 3 Korean chars, it doesn't work.

There are obvious few symptoms of it.

  • missing chars
  • and eventually freezing editor
  • at every end of line, we have to type return key twice to change line.

First one, I just typed 3 Korean chars, 언제나
but you can see only two.

korean-missing-chars

And more type, more broken. you can see even freezing at some moment and go on at another moment.
korean-missing-chars

What's the expected behavior?

  • No missing chars
  • No need to type Enter key end of line

I've read your principles very well. I hope we can use your editor!

@doortts
Copy link
Author

doortts commented May 3, 2018

update 18.05.03

According to the test of http://slatejs.org/#/rich-text

It seems Korean character disappearing problem is solved now.

Remaining problem is no new line when to type Enter key.
When type Enter in the middle of compositioning state, it just ened composition state and no new line.

I think this problem is related with composition state.

Even though it isn't 'compositionend', when user type Enter key, the new line should be followed instantly.

Example.

I typed few Korean (one of CJK) and pressed Enter key.
It should be ended with new line.

Draft.js: Working right.
draft-case

Slate.js: I typed Enter key in the end. But no new line. Just cursor moved and compositionend state.

slate-case

See: https://developer.mozilla.org/en-US/docs/Web/Events/compositionend

I really want to make some slate plugin contribution for Korean. But IME problem stopped me already few times.

@ianstormtaylor I need your help.

@designforhuman
Copy link

I have the same issue here.

@doortts
Copy link
Author

doortts commented Sep 2, 2018

@ianstormtaylor
We've been trying to change our main markdown editor.
At first, as like mentioned above, we had tried to adopt Slate editor. But unfortunately, we had to wait until this problem is resolved. And it seems it doesn't resolve, yet.

Recently, another guy recommended us 'StackEdit'. it was a very good editor, too.
But sadly, the same problem existed. So, I reported it.
And a day ago, they found the way to fix it.

benweet/stackedit#1376

I hope also it will be helpful to Slate editor.
Thanks!

@doortts
Copy link
Author

doortts commented Oct 2, 2018

@ianstormtaylor Is there any update?
Or if you can explain the codes of composing chars or events, I'll participate in investigating it.

@nayunhwan
Copy link

I have another issue related to Korean.

After typing Korean, In order to remove all string in a line at once time, I pressed cmd + del.
Then, the editor showed the error message and broke down.

But this issue had not happened in English.

slate 1

@ianstormtaylor
Copy link
Owner

Closing in favor of #2368, if you think this is unrelated let me know and we can reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants