Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename `*ByPath` commands to `*AtPath` #2859

Closed
ianstormtaylor opened this issue Jun 7, 2019 · 1 comment
Closed

rename `*ByPath` commands to `*AtPath` #2859

ianstormtaylor opened this issue Jun 7, 2019 · 1 comment

Comments

@ianstormtaylor
Copy link
Owner

@ianstormtaylor ianstormtaylor commented Jun 7, 2019

Do you want to request a feature or report a bug?

Improvement.

What's the current behavior?

We started with the *ByKey commands, where "by" makes sense, and added the *ByPath commands later. Since they took the same arguments, it felt like it made sense to keep the same "by" preposition, instead of the more natural "at".

What's the expected behavior?

But with the removal of the key-based commands of #2858, and our existing use of "at" for range commands, it makes more sense to have *AtPath and *AtRange together. (And also *AtPoint in the future.)

@ianstormtaylor

This comment has been minimized.

Copy link
Owner Author

@ianstormtaylor ianstormtaylor commented Nov 28, 2019

Fixed by #3093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.