Fix Paste without Formatting / Paste and Match Style producing uneditable text nodes. #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for fixing this bug @Killavus ! |
pzhine
pushed a commit
to databyss-org/slate
that referenced
this issue
May 17, 2020
…able text nodes. (ianstormtaylor#3415) * handle plaintext-only pastes using onPaste handler, regardless of browser * remove extra console.log; merge code paths in onPaste - they contain the same code
lukesmurray
pushed a commit
to lukesmurray/slate
that referenced
this issue
Feb 5, 2021
…able text nodes. (ianstormtaylor#3415) * handle plaintext-only pastes using onPaste handler, regardless of browser * remove extra console.log; merge code paths in onPaste - they contain the same code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Is this adding or improving a feature or fixing a bug?
Fixing a bug.
What's the new behavior?
This fixes #3414. Basically right now Paste and Match Style type of pasting from Chrome is working properly - as well as
mod+shift+vshortcut from other browsers.How does this change work?
Since these types of pastes are not emitting
beforeinputevents, I handle them inpasteevent handler. After that it's just a matter of simply passing them toinsertDataofReactEditor. I want to minimize the surface area of change, so this behavior is triggered only for pastes having exclusivelytext/plainClipboardData in them.Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)Does this fix any issues or need any specific reviewers?
Fixes: #3414
Reviewers: @