Fix Paste without Formatting / Paste and Match Style producing uneditable text nodes. #3415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Is this adding or improving a feature or fixing a bug?
Fixing a bug.
What's the new behavior?
This fixes #3414. Basically right now Paste and Match Style type of pasting from Chrome is working properly - as well as
mod+shift+v
shortcut from other browsers.How does this change work?
Since these types of pastes are not emitting
beforeinput
events, I handle them inpaste
event handler. After that it's just a matter of simply passing them toinsertData
ofReactEditor
. I want to minimize the surface area of change, so this behavior is triggered only for pastes having exclusivelytext/plain
ClipboardData in them.Have you checked that...?
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)Does this fix any issues or need any specific reviewers?
Fixes: #3414
Reviewers: @