Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker loader eslint support and documentation #1

Open
wants to merge 13 commits into
base: worker-loader
from

Conversation

@mattdarveniza
Copy link

commented Apr 5, 2019

Will have to rebase with master to see the meaningful changes.

  • Have added eslint overrides to allow usage of self in *.worker files
  • Added general documentation on usage of works with create-react-app, as well as Typescript specific usage.
iansu and others added 9 commits Nov 23, 2018

@mattdarveniza mattdarveniza changed the title Worker loader Worker loader eslint support and documentation Apr 5, 2019

@iansu iansu force-pushed the iansu:worker-loader branch from 6914756 to 9cc7667 Apr 5, 2019

@mattdarveniza mattdarveniza requested a review from iansu as a code owner Apr 8, 2019

@mattdarveniza

This comment has been minimized.

Copy link
Author

commented Apr 11, 2019

Alright have merged changes into this so tests pass now, should be good to merge if you're happy with it @iansu

@mattdarveniza mattdarveniza referenced this pull request Apr 17, 2019
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.