Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Retain cycles in TENode #2

merged 1 commit into from Jun 5, 2012


None yet
2 participants

artisonian commented Jun 5, 2012

In TENode.h, child shapes hold a strong reference to their parents (which causes retain cycles). Since the parent object "owns" the child (i.e., contains it), the child shouldn't have a strong reference to its parent.

I've made the parent property a weak reference in order to fix the issue.

ianterrell added a commit that referenced this pull request Jun 5, 2012

Merge pull request #2 from artisonian/master
Fixes retain cycle in TENode parent/child relationship

@ianterrell ianterrell merged commit 17f133c into ianterrell:master Jun 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment