Update 'show me the email' to use current Launchy API (using launchy-2.0.5) #23

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@dznz
Contributor

dznz commented Aug 5, 2011

Refers this deprecation warning:

WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
WARNING:
WARNING: /Library/Ruby/Gems/1.8/gems/pickle-0.4.8/lib/pickle/email.rb:34:in open_in_browser' WARNING: def open_in_browser(path) # :nodoc WARNING: require "launchy" WARNING: Launchy::Browser.run(path) WARNING: rescue LoadError WARNING: warn "Sorry, you need to install launchy to open emails:gem install launchy`"
WARNING:
WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new

Update email open_in_browser function to use current Launchy API
Refers this deprecation warning:

WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
WARNING: 
WARNING: /Library/Ruby/Gems/1.8/gems/pickle-0.4.8/lib/pickle/email.rb:34:in `open_in_browser'
WARNING:     def open_in_browser(path) # :nodoc
WARNING:       require "launchy"
WARNING:       Launchy::Browser.run(path)
WARNING:     rescue LoadError
WARNING:       warn "Sorry, you need to install launchy to open emails: `gem install launchy`"
WARNING: 
WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new
@dznz

This comment has been minimized.

Show comment
Hide comment
@dznz

dznz Aug 5, 2011

Contributor

Apologies if the format for this pull request is poor: this is my first one. Do please let me know if I'm Doing It Wrong.

Contributor

dznz commented Aug 5, 2011

Apologies if the format for this pull request is poor: this is my first one. Do please let me know if I'm Doing It Wrong.

@endofunky

This comment has been minimized.

Show comment
Hide comment
@endofunky

endofunky Nov 20, 2011

Is this going to be merged at some point?

+1

Is this going to be merged at some point?

+1

@dznz

This comment has been minimized.

Show comment
Hide comment
@dznz

dznz Nov 22, 2011

Contributor

Hmmm, looks like development has been quiet overall since September. I'm sure Mr White will get to it in time, but in the meantime, feel free to pull my change :D

Contributor

dznz commented Nov 22, 2011

Hmmm, looks like development has been quiet overall since September. I'm sure Mr White will get to it in time, but in the meantime, feel free to pull my change :D

@chewi

This comment has been minimized.

Show comment
Hide comment
@chewi

chewi Nov 20, 2014

Collaborator

Merged.

Collaborator

chewi commented Nov 20, 2014

Merged.

@chewi chewi closed this Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment