Skip to content

Loading…

Update 'show me the email' to use current Launchy API (using launchy-2.0.5) #23

Closed
wants to merge 1 commit into from

3 participants

@dznz

Refers this deprecation warning:

WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
WARNING:
WARNING: /Library/Ruby/Gems/1.8/gems/pickle-0.4.8/lib/pickle/email.rb:34:in open_in_browser'
WARNING: def open_in_browser(path) # :nodoc
WARNING: require "launchy"
WARNING: Launchy::Browser.run(path)
WARNING: rescue LoadError
WARNING: warn "Sorry, you need to install launchy to open emails:
gem install launchy`"
WARNING:
WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new

@dznz dznz Update email open_in_browser function to use current Launchy API
Refers this deprecation warning:

WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
WARNING: 
WARNING: /Library/Ruby/Gems/1.8/gems/pickle-0.4.8/lib/pickle/email.rb:34:in `open_in_browser'
WARNING:     def open_in_browser(path) # :nodoc
WARNING:       require "launchy"
WARNING:       Launchy::Browser.run(path)
WARNING:     rescue LoadError
WARNING:       warn "Sorry, you need to install launchy to open emails: `gem install launchy`"
WARNING: 
WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new
2e1c03a
@dznz

Apologies if the format for this pull request is poor: this is my first one. Do please let me know if I'm Doing It Wrong.

@tobiassvn

Is this going to be merged at some point?

+1

@dznz

Hmmm, looks like development has been quiet overall since September. I'm sure Mr White will get to it in time, but in the meantime, feel free to pull my change :D

@chewi
Collaborator

Merged.

@chewi chewi closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 5, 2011
  1. @dznz

    Update email open_in_browser function to use current Launchy API

    dznz committed
    Refers this deprecation warning:
    
    WARNING: You made a call to a deprecated Launchy API. This call should be changed to 'Launchy.open( uri )'
    WARNING: I think I was able to find the location that needs to be fixed. Please go look at:
    WARNING: 
    WARNING: /Library/Ruby/Gems/1.8/gems/pickle-0.4.8/lib/pickle/email.rb:34:in `open_in_browser'
    WARNING:     def open_in_browser(path) # :nodoc
    WARNING:       require "launchy"
    WARNING:       Launchy::Browser.run(path)
    WARNING:     rescue LoadError
    WARNING:       warn "Sorry, you need to install launchy to open emails: `gem install launchy`"
    WARNING: 
    WARNING: If this is not the case, please file a bug. Please file a bug at https://github.com/copiousfreetime/launchy/issues/new
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/pickle/email.rb
View
2 lib/pickle/email.rb
@@ -31,7 +31,7 @@ def click_first_link_in_email(email)
protected
def open_in_browser(path) # :nodoc
require "launchy"
- Launchy::Browser.run(path)
+ Launchy.open(path)
rescue LoadError
warn "Sorry, you need to install launchy to open emails: `gem install launchy`"
end
Something went wrong with that request. Please try again.