Show layout names rather than keys in Preferences UI #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename some variables/functions to distinguish between keys and names
houndci-bot
reviewed
Feb 24, 2019
ianyh
requested changes
Feb 24, 2019
houndci-bot
reviewed
Feb 24, 2019
| BinarySpacePartitioningLayout.self | ||
| ] | ||
|
|
||
| static var layoutByKey: [String: Layout.Type] = Dictionary(uniqueKeysWithValues: zip( layoutClasses.map { ($0.layoutKey) }, layoutClasses )) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 144 characters (line_length)
|
The Travis build failed with |
|
I reran it. It seems like it was a transient Travis failure and not the tests. |
ianyh
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename some variables/functions to explicitly distinguish between layout keys and
names (avoid ambiguous term
layoutString). If you want, I can split this into two separate PRs, but I figured they are quite related.This should be a UI change only; functionality should not be affected. For instance, preferences storage is still by layout key, not layout name; it's just displayed as layout names.
With this PR, the layout keys should be entirely invisible to the average user, unless I'm missing something. This is advantageous for layouts where the key bears little resemblance to the name, e.g. key
middle-widewith name3Column Middle.