require_oauth decorator was always succeeding. #5

Merged
merged 1 commit into from Apr 6, 2013

2 participants

@datalogics-kam

verify_request() returns a tuple of (valid, oauth_request). The code was
treating it as if it returned just a bool, and since the never-empty
tuple was always truthy, requests always seemed to work.

Fixes ib-lundgren/flask-oauthprovider/#3

@datalogics-kam datalogics-kam require_oauth decorator was always succeeding.
verify_request() returns a tuple of (valid, oauth_request). The code was
treating it as if it returned just a bool, and since the never-empty
tuple was always truthy, requests always seemed to work.

Fixes ib-lundgren/flask-oauthprovider/#3
5249a17
@ib-lundgren
Owner

Thanks for the PR and sorry for the late reply. Ideally the unpacking would be done directly rather than unpacking but that's just details. Merging.

valid, oauth_request  = self.verify_request(...
@ib-lundgren ib-lundgren merged commit e671925 into ib-lundgren:master Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment