Simplified build #41
Merged
Simplified build #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes comparison with the Debian dependencies. pkg-config was missing.
Condition inclusion with HAVE_CONFIG_H so that DEFS remains a possible option.
Add missing lingot-defs.c.
Generation of the changelog introduces complexity for a very arguable benefit. A contributor would probably start with 'git clone' before possibly going offline. It is also possible to pass the 'foreign' option to automake, so that it does not require a ChangeLog in the first place.
The specfiles distribution lines have been added by a commit named 'Anjutized'. They do not seem to exist anymore.
GETTEXT_PACKAGE is redundant with PACKAGE. It is much easyer to pass LOCALEDIR via config.h (or DEFS).
AC_PREREQ: silents a warning AC_CONFIG_SRCDIR: seems a good precaution AM_MAINTAINER_MODE: https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html#maintainer_002dmode LT_INIT emits a warning if it is loaded before AM_PROG_AR. AC_ISC_POSIX: https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Posix-Variants.html AM_PROG_AR: libtool displays a warning if it is not explicit. AC_HEADER_STDC: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#AC_005fHEADER_005fSTDC PKG_CONFIG(l,...) now automatically AC_SUBSTs l_CFLAGS and l_LIBS.
Do not repeat the detail of ./configure --help in README.md. AC_ARG_WITH is recommended instead of AC_ARG_ENABLE for external dependencies. The choices in ./configure are now * if available (the default) * explicit yes (fail if unavailable) * explicit no Directly changing user variables like CFLAGS from configure.ac or Makefile.am causes a lot of problems. Also, in automake, CFLAGS is always appended, and AM_CFLAGS can be ignored nowadays in favor of lingot_CFLAGS. Only run the tests if libcunit is available. Pass each l_CFLAGS l_LIBS for consistency, even if some happen to be empty for now (like OSS_CFLAGS or PULSEAUDIO_CFLAGS). On the other hand, the exemples do really not need GTK. The -pthread option is intended for both cflags and ldflags.
Section 7.3 of the Automake manual gives excellent reasons to avoid recursive Makefiles even if the directory structure is not flat. Take the occasion to remove tabulations and sort lists. Use dist_ prefix instead of EXTRA_DIST.
The installation directory was empty, which does not seem safe anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes by Nicolas Boulenguez simplifying the build system.