Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecations using php 8.1 #45

Merged
merged 1 commit into from Nov 15, 2021

Conversation

franmomu
Copy link
Contributor

Using PHP 8.1, it triggers deprecations for implementations of some core interfaces without a return type.

Adding the return type will break BC, so using #[\ReturnTypeWillChange] attribute will suppress the deprecation.

These deprecations can be seen merging #43 and #44

@dannyvankooten dannyvankooten merged commit 59831d6 into ibericode:master Nov 15, 2021
@dannyvankooten
Copy link
Member

Hey @franmomu,

Great work, love how you went about solving this. Thank you!

@franmomu franmomu deleted the deprecations_php81 branch November 16, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants