Sourcery refactored main branch #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| uuid = res[0]['uuid'] | ||
|
|
||
| return uuid | ||
| return res[0]['uuid'] |
Author
There was a problem hiding this comment.
Function Client.get_organization_id refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-81
to
+79
| attachment_response = self.upload_attachment(attachment) | ||
| if attachment_response: | ||
| if attachment_response := self.upload_attachment(attachment): |
Author
There was a problem hiding this comment.
Function Client.send_message refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# Returns answer
Comment on lines
-153
to
+147
| if response.status_code == 204: | ||
| return True | ||
| else: | ||
| return False | ||
| return response.status_code == 204 |
Author
There was a problem hiding this comment.
Function Client.delete_conversation refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Comment on lines
-184
to
+175
| formatted_uuid = f"{random_uuid_str[0:8]}-{random_uuid_str[9:13]}-{random_uuid_str[14:18]}-{random_uuid_str[19:23]}-{random_uuid_str[24:]}" | ||
| return formatted_uuid | ||
| return f"{random_uuid_str[:8]}-{random_uuid_str[9:13]}-{random_uuid_str[14:18]}-{random_uuid_str[19:23]}-{random_uuid_str[24:]}" |
Author
There was a problem hiding this comment.
Function Client.generate_uuid refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (
remove-redundant-slice-index)
Comment on lines
-248
to
+238
| if response.status_code == 200: | ||
| return response.json() | ||
| else: | ||
| return False | ||
| return response.json() if response.status_code == 200 else False |
Author
There was a problem hiding this comment.
Function Client.upload_attachment refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-281
to
+268
| if response.status_code == 200: | ||
| return True | ||
| else: | ||
| return False | ||
| return response.status_code == 200 |
Author
There was a problem hiding this comment.
Function Client.rename_chat refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Comment on lines
-5
to
-8
| cookie = os.environ.get('cookie') | ||
| if not cookie: | ||
| if cookie := os.environ.get('cookie'): | ||
| return cookie | ||
| else: | ||
| raise ValueError("Please set the 'cookie' environment variable.") | ||
| return cookie |
Author
There was a problem hiding this comment.
Function get_cookie refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!