Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 5.0 default image to PHP 8.3 #88

Merged
merged 1 commit into from
May 3, 2024
Merged

Bump 5.0 default image to PHP 8.3 #88

merged 1 commit into from
May 3, 2024

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Apr 26, 2024 •
edited
Loading

🎫 Issue IBX-8154

Description:

To unblock work on setting PHP 8.3 as minimum and default for v5.

For QA:

Documentation:

@micszo micszo marked this pull request as ready for review April 26, 2024 08:35
@micszo micszo mentioned this pull request Apr 26, 2024
Closed
@micszo micszo marked this pull request as draft April 26, 2024 10:07
@micszo
Copy link
Contributor Author

micszo commented Apr 26, 2024

Closing in favour of ibexa/gh-workflows#51.

@micszo micszo closed this Apr 26, 2024
@micszo micszo deleted the bump-5.0-default-image branch April 26, 2024 10:15
@micszo micszo restored the bump-5.0-default-image branch April 26, 2024 18:08
@micszo micszo reopened this Apr 26, 2024
@micszo micszo marked this pull request as ready for review April 26, 2024 18:31
@micszo
Copy link
Contributor Author

micszo commented Apr 26, 2024

This in fact is used by https://github.com/ibexa/rest/blob/main/.github/workflows/integration-tests-callable.yaml#L42 and also by https://github.com/ibexa/http-cache/blob/main/.github/workflows/ci.yaml#L70.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@adamwojs adamwojs merged commit 39d0e04 into main May 3, 2024
6 checks passed
@adamwojs adamwojs deleted the bump-5.0-default-image branch May 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@mnocon mnocon Awaiting requested review from mnocon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micszo @adamwojs @Steveb-p