Remove eTID; filter permissions on module #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only show the feed-specific permissions relevant for the enabled modules for the application instance.
evansiroky
approved these changes
Sep 26, 2019
evansiroky
suggested changes
Sep 26, 2019
Contributor
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
There are some linting errors that need fixing for Travis builds to pass.
Codecov Report
@@ Coverage Diff @@
## dev #491 +/- ##
=========================================
- Coverage 19% 16.34% -2.67%
=========================================
Files 309 309
Lines 16423 15318 -1105
Branches 5031 4669 -362
=========================================
- Hits 3122 2503 -619
+ Misses 11486 10952 -534
- Partials 1815 1863 +48
Continue to review full report at Codecov.
|
Contributor
Author
|
Could you approve this and merge, @evansiroky? |
evansiroky
approved these changes
Oct 4, 2019
Contributor
Author
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
In the user admin part of the application, only show the feed-specific permissions relevant for the enabled modules for the application instance. For example, if the alerts module is not enabled, do not show permissions relevant to editing/approving GTFS-rt alerts.