Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSpinLock is unsafe in iOS #43

Closed
vampirewalk opened this issue Jan 14, 2016 · 2 comments
Closed

OSSpinLock is unsafe in iOS #43

vampirewalk opened this issue Jan 14, 2016 · 2 comments
Labels
bug discussion

Comments

@vampirewalk
Copy link

Hi ibireme, thank you for bring us this great library.
My concern is that OSSpinLock is unsafe in iOS. It does not guarantee progress in the face of priority inversion.

http://mjtsai.com/blog/2015/12/16/osspinlock-is-unsafe/
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000372.html
@ibireme
Copy link
Owner

ibireme commented Jan 14, 2016

Thanks very much!
I'll do some research and fix it later.

ibireme added a commit that referenced this issue Jan 15, 2016
@ibireme
Stop using spinlocks #43
ff99195 
Apple engineers have pointed out that OSSpinLocks are vulnerable to live locking
on iOS in cases of priority inversion:

. http://mjtsai.com/blog/2015/12/16/osspinlock-is-unsafe/
. https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000372.html
@ibireme
Copy link
Owner

ibireme commented Jan 17, 2016

Fixed

@ibireme ibireme closed this as completed Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibireme @vampirewalk