feat(snowflake): support reductions in window functions via automatic…

… ordering
ibis-project · Dec 6, 2022 · 0234e5c · 0234e5c
1 parent 8f4808c
commit 0234e5c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/ibis/backends/snowflake/__init__.py b/ibis/backends/snowflake/__init__.py
@@ -33,6 +33,7 @@ class SnowflakeExprTranslator(AlchemyExprTranslator):
         ops.Lag,
         ops.Lead,
     )
+    _require_order_by = (*AlchemyExprTranslator._require_order_by, ops.Reduction)
 
 
 class SnowflakeCompiler(AlchemyCompiler):

diff --git a/ibis/backends/tests/test_window.py b/ibis/backends/tests/test_window.py
@@ -424,13 +424,7 @@ def test_grouped_bounded_preceding_window(backend, alltypes, df, window_fn):
     ('ordered'),
     [
         param(True, id='ordered', marks=pytest.mark.notimpl(["dask", "pandas"])),
-        param(
-            False,
-            id='unordered',
-            marks=[
-                pytest.mark.notyet(["snowflake"], reason="backend requires ordering")
-            ],
-        ),
+        param(False, id='unordered'),
     ],
 )
 @pytest.mark.notimpl(["datafusion", "polars"])
@@ -486,9 +480,6 @@ def test_grouped_unbounded_window(
             lambda df: pd.Series([df.double_col.mean()] * len(df.double_col)),
             False,
             id='unordered-mean',
-            marks=[
-                pytest.mark.notyet(["snowflake"], reason="backend requires ordering")
-            ],
         ),
         param(
             lambda t, win: mean_udf(t.double_col).over(win),