fix(duckdb): add missing types

ibis-project · Sep 13, 2022 · 59bad07 · 59bad07
1 parent 05561e0
commit 59bad07
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/ibis/backends/duckdb/datatypes.py b/ibis/backends/duckdb/datatypes.py
@@ -36,6 +36,7 @@
     int16,
     int32,
     int64,
+    json,
     spaceless,
     spaceless_string,
     string,
@@ -63,9 +64,14 @@ def parse(text: str, default_decimal_parameters=(18, 3)) -> DataType:
         | spaceless_string("double", "float8").result(float64)
         | spaceless_string("real", "float4", "float").result(float32)
         | spaceless_string("smallint", "int2", "short").result(int16)
-        | spaceless_string("timestamp", "datetime").result(
-            Timestamp(timezone="UTC")
-        )
+        | spaceless_string(
+            "timestamp_tz",
+            "timestamp_sec",
+            "timestamp_ms",
+            "timestamp_ns",
+            "timestamp",
+            "datetime",
+        ).result(Timestamp(timezone="UTC"))
         | spaceless_string("date").result(date)
         | spaceless_string("time").result(time)
         | spaceless_string("tinyint", "int1").result(int8)
@@ -82,6 +88,7 @@ def parse(text: str, default_decimal_parameters=(18, 3)) -> DataType:
             "text",
             "string",
         ).result(string)
+        | spaceless_string("json").result(json)
     )
 
     @p.generate

diff --git a/ibis/backends/duckdb/tests/test_datatypes.py b/ibis/backends/duckdb/tests/test_datatypes.py
@@ -58,6 +58,11 @@
     ),
     T=dt.Array(dt.Array(dt.int32)),
     U=dt.Array(dt.Array(dt.int32)),
+    V=dt.Timestamp("UTC"),
+    W=dt.Timestamp("UTC"),
+    X=dt.Timestamp("UTC"),
+    Y=dt.Timestamp("UTC"),
+    Z=dt.json,
 )
 
 
@@ -113,6 +118,11 @@
             ("S", "STRUCT(a INT, b TEXT, c LIST<MAP<TEXT, LIST<FLOAT8>>>)"),
             ("T", "LIST<LIST<INTEGER>>"),
             ("U", "INTEGER[][]"),
+            ("V", "TIMESTAMP_TZ"),
+            ("W", "TIMESTAMP_SEC"),
+            ("X", "TIMESTAMP_MS"),
+            ("Y", "TIMESTAMP_NS"),
+            ("Z", "JSON"),
         ]
     ],
 )