New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL backend #1224

Closed
kszucs opened this Issue Nov 14, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@kszucs
Member

kszucs commented Nov 14, 2017

I guess mysql would be a nice to have backend.

Should it be based on the alchemy backend or the sql compiler (like impala, clickhouse and bigquery)?

@wesm

This comment has been minimized.

Member

wesm commented Nov 14, 2017

This would also provide MemSQL support. I will see if anyone from over there would be interested in contributing

@kszucs

This comment has been minimized.

Member

kszucs commented Nov 14, 2017

Sounds great, thanks!

@cpcloud

This comment has been minimized.

Member

cpcloud commented Nov 14, 2017

@kszucs This should be based on the alchemy backend.

@kszucs

This comment has been minimized.

Member

kszucs commented Nov 14, 2017

@cpcloud BTW what's the advantage of maintaining both sqlalchemy and custom compiler backends?

@wesm

This comment has been minimized.

Member

wesm commented Nov 14, 2017

Depends on how well sqlalchemy supports the underlying SQL backend. In the case of Impala and BigQuery there's a lot of stuff that is challenging to support in SQLAlchemy (or maybe it's that we don't know how to use it well enough)

@kszucs

This comment has been minimized.

Member

kszucs commented Nov 14, 2017

I get it, but also bothers me a bit.

When I look at ibis' custom compiler it feels like another sqlalchemy.
When I look at sqlalchemy backends it feels like I have double vision, mapping ibis expr to sa expr.

Couldn't we move away from either one? (I know there are pros&cons for both backend types)

@cpcloud cpcloud added this to the Future milestone Nov 24, 2017

@cpcloud cpcloud closed this in 36251a1 Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment