New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: The nullable property is not propagated through primitive types #1289

Closed
cpcloud opened this Issue Jan 20, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@cpcloud
Member

cpcloud commented Jan 20, 2018

Because the type() method just blindly returns instances of particular types (which are nullable by default).

@cpcloud cpcloud added the bug label Jan 20, 2018

@cpcloud cpcloud added this to the 0.13 milestone Jan 20, 2018

@cpcloud cpcloud self-assigned this Jan 20, 2018

@cpcloud cpcloud modified the milestones: 0.13, 0.14 Jan 29, 2018

@kszucs

This comment has been minimized.

Member

kszucs commented Mar 25, 2018

This should be resolved by #1366 because datatypes are passed to ValueExpr objects.

@cpcloud cpcloud referenced this issue Apr 2, 2018

Closed

Rules refactor #1366

@kszucs

This comment has been minimized.

Member

kszucs commented Apr 5, 2018

@cpcloud What should be the promotion logic for operation involving both nullable and non-nullable operands?

I guess if any of the operands are nullable then the result should be nullable, please confirm.

@kszucs

This comment has been minimized.

Member

kszucs commented Apr 5, 2018

Ohh, the implicit casting already nicely handles that.

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 16, 2018

@kszucs This was fixed by the PR that added Argument right?

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jul 16, 2018

Ah yes, looks like it does.

@cpcloud cpcloud closed this Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment