Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for sqlalchemy >= 1.2? #1384

Closed
kszucs opened this issue Mar 16, 2018 · 1 comment
Closed

Support for sqlalchemy >= 1.2? #1384

kszucs opened this issue Mar 16, 2018 · 1 comment
Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs
Milestone
0.14

Comments

@kszucs
Copy link
Member

kszucs commented Mar 16, 2018

@cpcloud I've manually installed the dependencies and it took me fair amount of time to figure out that the problem is newer sqlalchemy than 1.1. Only SQLite tests were breaking.

How much effort would it be to support newer sqlalchemy too?
@cpcloud cpcloud added this to the 0.14 milestone Mar 16, 2018
@cpcloud
Copy link
Member

cpcloud commented Mar 16, 2018

I'm not sure, I haven't had a chance to look into why this breaks sqlite tests. We should look into it for 0.14.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs labels Mar 16, 2018
@cpcloud cpcloud mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Upgrade SQLAlchemy dependency to latest version cpcloud/ibis
2 participants
@cpcloud @kszucs