Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ibis support for geospatial data types #1665

Closed
xmnlab opened this Issue Oct 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@xmnlab
Copy link
Collaborator

xmnlab commented Oct 25, 2018

@cpcloud @kszucs

we are planning to add support for geospatial data types and functions into ibis [1].

it seems it should be put inside the common interface. so if anyone is interested in this implementation we can work together.

we will check geopandas and shapely to check name and signature standard

cc @tonyfast

[1] Quansight/mapd#21 (comment)

@xmnlab xmnlab changed the title Add Ibis support for geospatial data types and functions Add Ibis support for geospatial data types Feb 21, 2019

kszucs added a commit that referenced this issue Feb 22, 2019

[MapD] Add geo spatial datatype support
Resolves partial #1665    - added support to geo spatial data    MapD
GEO spatial functions support should be addressed in another PR

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1666 from xmnlab/add_geospatial_support and squashes the following commits:

d84150b [Ivan Ogasawara] Update docker and ci
479cb54 [Ivan Ogasawara] Fixed small issues
c4f8111 [Krisztián Szűcs] don't use ibis.null function as a literal
45ddbf8 [Krisztián Szűcs] support non-inferable types in ibis.literal
688caee [Krisztián Szűcs] don't infer tuple types
a6f5f00 [Krisztián Szűcs] plus test
7f90d14 [Krisztián Szűcs] flake8
c27491e [Ivan Ogasawara] Added initial structure for spatial data support

@xmnlab xmnlab referenced this issue Mar 1, 2019

Closed

[MapD] Added Geospatial functions #1678

20 of 20 tasks complete

kszucs added a commit that referenced this issue Mar 6, 2019

[MapD] Added Geospatial functions
This PR solves #1665 and solves #1707      Add Geo Spatial functions
on the main structure and define these functions inside MapD backend.
References:     - Quansight/mapd#21  -
https://www.omnisci.com/docs/latest/5_geospatial_functions.html
Depends on #1666 ( PR 1666 was used as base for the current PR)     #
Geospatial functions    - Geometry/Geography Constructors    - [x]
ST_GeomFromText(WKT) - using literals    - [x] ST_GeogFromText(WKT) -
using literals  - Geometry Editors    - ~ST_Transform (Returns a new
geometry with its coordinates transformed to a different spatial
reference system.)~    - ~ST_SetSRID (Sets the SRID on a geometry to a
particular integer value.)~  - Geometry Accessors    - [x] ST_X
(Return the X coordinate of the point, or NULL if not available. Input
must be a point.)    - [x] ST_Y (Return the Y coordinate of the point,
or NULL if not available. Input must be a point.)    - [x] ST_XMin
(Returns Y minima of a bounding box 2d or 3d or a geometry.)    - [x]
ST_XMax (Returns X maxima of a bounding box 2d or 3d or a geometry.)
- [x] ST_YMin (Returns Y minima of a bounding box 2d or 3d or a
geometry.)    - [x] ST_YMax (Returns Y maxima of a bounding box 2d or
3d or a geometry.)    - [x] ST_StartPoint (Returns the first point of
a LINESTRING geometry as a POINT or NULL if the input parameter is not
a LINESTRING.)    - [x] ST_EndPoint (Returns the last point of a
LINESTRING geometry as a POINT or NULL if the input parameter is not a
LINESTRING.)    - [x] ST_PointN (Return the Nth point in a single
linestring in the geometry. Negative values are counted backwards from
the end of the LineString, so that -1 is the last point. Returns NULL
if there is no linestring in the geometry.)    - [x] ST_NPoints
(Return the number of points in a geometry. Works for all geometries.)
- [x] ST_NRings (If the geometry is a polygon or multi-polygon returns
the number of rings. It counts the outer rings as well.)    - [x]
ST_SRID (Returns the spatial reference identifier for the ST_Geometry)
- Spatial Relationships and Measurements    - [x] ST_Distance    - [x]
ST_Contains    - [x] ST_Area    - [x] ST_Perimeter    - [x] ST_Length
- [x] ST_MaxDistance  - Extra    - ~CastToGeography~ TODO: will be
added in a new PR.

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1678 from xmnlab/geospatial_functions and squashes the following commits:

4f94baf [Krisztián Szűcs] update docs conda dependencies
44dfaa6 [Krisztián Szűcs] remove IBIS_TEST_DOWNLOAD_DIRECTORY from the docs container as well
a96c0fd [Ivan Ogasawara] Added pymapd dependence from conda
a1e177d [Krisztián Szűcs] use pkg_resources to get pymapd's version
2cc2285 [Krisztián Szűcs] fox download path in docker-compose
e4d4410 [Krisztián Szűcs] more robost testing data download script; updated requirements
bb4c8f4 [Krisztián Szűcs] use the zip github endpoint to download the repository
4c3969c [Ivan Ogasawara] Added more tests
@kszucs

This comment has been minimized.

Copy link
Member

kszucs commented Mar 6, 2019

resolved by #1678 and #1666

@kszucs kszucs closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.