Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OmniSci Sample method #1680

Closed
saulshanabrook opened this issue Dec 28, 2018 · 5 comments · Fixed by #1683
Closed

Support OmniSci Sample method #1680

saulshanabrook opened this issue Dec 28, 2018 · 5 comments · Fixed by #1683

Comments

@saulshanabrook
Copy link
Contributor

OmniSci supports the SAMPLE aggregate method that:

Returns one sample value from aggregated column x.

I don't believe this is implemented in the Ibis wrapper.
@saulshanabrook
Copy link
Contributor Author

cc @xmnlab

To implement this, would we:

@saulshanabrook
Copy link
Contributor Author

I think Arbitrary could be the right operation: #1230

So we would just have to add a mapping to OmniSci to map this to sample

@saulshanabrook
Copy link
Contributor Author

It looks like it is taking the last of groupby: https://github.com/omnisci/mapd-core/blob/ce5c83d782f30b0ef62dff98fff530fdd65e14d7/QueryEngine/Execute.cpp#L733-L740

@saulshanabrook
Copy link
Contributor Author

I am working on adding this.

@xmnlab
Copy link
Contributor

xmnlab commented Dec 28, 2018

in the documentation:

Note: This was previously LAST_SAMPLE, which is now deprecated.

(https://www.omnisci.com/docs/latest/5_math.html#aggregate-function-support-1)

so a translation from arbitrary last to sample should works fine

saulshanabrook added a commit to Quansight/ibis that referenced this issue Dec 28, 2018
@saulshanabrook
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
a7e2310 
…ct#1680)
@saulshanabrook saulshanabrook mentioned this issue Dec 28, 2018
Merged
kszucs pushed a commit to Quansight/ibis that referenced this issue Jan 31, 2019
@saulshanabrook @kszucs
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
024ea6f 
…ct#1680)
kszucs pushed a commit to Quansight/ibis that referenced this issue Jan 31, 2019
@saulshanabrook @kszucs
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
f44fa15 
…ct#1680)
@xmnlab xmnlab assigned xmnlab and unassigned xmnlab Mar 7, 2019
@xmnlab xmnlab added the mapd label Mar 7, 2019
xmnlab pushed a commit to Quansight/ibis that referenced this issue Mar 20, 2019
@saulshanabrook @xmnlab
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
0020ccc 
…ct#1680)
xmnlab pushed a commit to Quansight/ibis that referenced this issue Mar 20, 2019
@saulshanabrook @xmnlab
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
4090819 
…ct#1680)

Added tests; changed from first to last;
xmnlab pushed a commit to Quansight/ibis that referenced this issue Mar 22, 2019
@saulshanabrook @xmnlab
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
30b51ef 
…ct#1680)

Added tests; changed from first to last;

Changed df_alltypes scope to module

Changed api.arbitrary how param default to None

Applied suggestions from review
xmnlab pushed a commit to Quansight/ibis that referenced this issue Mar 22, 2019
@saulshanabrook @xmnlab
Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
f8d9ee1 
…ct#1680)

Added tests; changed from first to last;

Changed df_alltypes scope to module

Changed api.arbitrary how param default to None

Applied suggestions from review
cpcloud pushed a commit that referenced this issue Mar 23, 2019
@saulshanabrook @cpcloud
[OmniSci/MapD] Add support for arbitrary aggregate
f24d464 
This fixes #1680 by adding support for the `arbitrary` aggregate in
MapD by mapping it to the `SAMPLE` function.
Author: Saul Shanabrook <s.shanabrook@gmail.com>

Closes #1683 from saulshanabrook/omnisci-sample and squashes the following commits:

f8d9ee1 [Saul Shanabrook] Add support for arbitrary aggregate in OmniSci/MapD (fixes #1680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OmniSci/MapD] Add support for arbitrary aggregate Quansight/ibis
2 participants
@saulshanabrook @xmnlab