Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OmniSci Sample method #1680

Closed
saulshanabrook opened this Issue Dec 28, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@saulshanabrook
Copy link
Contributor

commented Dec 28, 2018

OmniSci supports the SAMPLE aggregate method that:

Returns one sample value from aggregated column x.

I don't believe this is implemented in the Ibis wrapper.

@saulshanabrook

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

cc @xmnlab

To implement this, would we:

@saulshanabrook

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

I think Arbitrary could be the right operation: #1230

So we would just have to add a mapping to OmniSci to map this to sample

@saulshanabrook

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

@saulshanabrook

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

I am working on adding this.

@xmnlab

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2018

in the documentation:

Note: This was previously LAST_SAMPLE, which is now deprecated.

(https://www.omnisci.com/docs/latest/5_math.html#aggregate-function-support-1)

so a translation from arbitrary last to sample should works fine

kszucs added a commit to Quansight/ibis that referenced this issue Jan 31, 2019

kszucs added a commit to Quansight/ibis that referenced this issue Jan 31, 2019

@xmnlab xmnlab assigned xmnlab and unassigned xmnlab Mar 7, 2019

@xmnlab xmnlab added the mapd label Mar 7, 2019

xmnlab added a commit to Quansight/ibis that referenced this issue Mar 20, 2019

xmnlab added a commit to Quansight/ibis that referenced this issue Mar 22, 2019

Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
…ct#1680)

Added tests; changed from first to last;

Changed df_alltypes scope to module

Changed api.arbitrary how param default to None

Applied suggestions from review

xmnlab added a commit to Quansight/ibis that referenced this issue Mar 22, 2019

Add support for arbitrary aggregate in OmniSci/MapD (fixes ibis-proje…
…ct#1680)

Added tests; changed from first to last;

Changed df_alltypes scope to module

Changed api.arbitrary how param default to None

Applied suggestions from review

cpcloud added a commit that referenced this issue Mar 23, 2019

[OmniSci/MapD] Add support for arbitrary aggregate
This fixes #1680 by adding support for the `arbitrary` aggregate in
MapD by mapping it to the `SAMPLE` function.
Author: Saul Shanabrook <s.shanabrook@gmail.com>

Closes #1683 from saulshanabrook/omnisci-sample and squashes the following commits:

f8d9ee1 [Saul Shanabrook] Add support for arbitrary aggregate in OmniSci/MapD (fixes #1680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.