Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MapD] Missing entry for float32 in _sql_type_names at operations.py #1753

Closed
xmnlab opened this issue Apr 4, 2019 · 0 comments · Fixed by #1755
Closed

[MapD] Missing entry for float32 in _sql_type_names at operations.py #1753

xmnlab opened this issue Apr 4, 2019 · 0 comments · Fixed by #1755
Assignees
@xmnlab
Labels
bug Incorrect behavior inside of ibis

Comments

@xmnlab
Copy link
Contributor

xmnlab commented Apr 4, 2019

In _sql_type_names at https://github.com/ibis-project/ibis/blob/master/ibis/mapd/operations.py#L18 , it is missing a entry for 'float32': 'float'
@xmnlab xmnlab self-assigned this Apr 4, 2019
@xmnlab xmnlab added the bug Incorrect behavior inside of ibis label Apr 4, 2019
@xmnlab xmnlab mentioned this issue Apr 4, 2019
Merged
cpcloud pushed a commit that referenced this issue Apr 5, 2019
@xmnlab @cpcloud
FEAT: [mapd] Added float32 and geospatial types for create table from…
80db366 
… schema

resolves #1753
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1755 from xmnlab/add-float32-sql-type-names and squashes the following commits:

cea890e [Ivan Ogasawara] Applied suggestion from review
28bf106 [Ivan Ogasawara] Applied suggestion from review
435b525 [Ivan Ogasawara] Applied changes from review.
5316f93 [Ivan Ogasawara] [mapd] Added float32 and geospatial types for create table from schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xmnlab xmnlab

Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT: [mapd] Added float32 and geospatial types for create table from schema Quansight/ibis
1 participant
@xmnlab