Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapD] Missing entry for `float32` in `_sql_type_names` at operations.py #1753

Closed
xmnlab opened this issue Apr 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@xmnlab
Copy link
Collaborator

commented Apr 4, 2019

In _sql_type_names at https://github.com/ibis-project/ibis/blob/master/ibis/mapd/operations.py#L18 , it is missing a entry for 'float32': 'float'

@xmnlab xmnlab self-assigned this Apr 4, 2019

@xmnlab xmnlab added the bug label Apr 4, 2019

@cpcloud cpcloud closed this in #1755 Apr 5, 2019

cpcloud added a commit that referenced this issue Apr 5, 2019

FEAT: [mapd] Added float32 and geospatial types for create table from…
… schema

resolves #1753
Author: Ivan Ogasawara <ivan.ogasawara@gmail.com>

Closes #1755 from xmnlab/add-float32-sql-type-names and squashes the following commits:

cea890e [Ivan Ogasawara] Applied suggestion from review
28bf106 [Ivan Ogasawara] Applied suggestion from review
435b525 [Ivan Ogasawara] Applied changes from review.
5316f93 [Ivan Ogasawara] [mapd] Added float32 and geospatial types for create table from schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.