Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibis.postgres table expressions dont recognize macaddr datatype #2461

Closed
esamuel1 opened this issue Oct 12, 2020 · 1 comment · Fixed by #2464
Closed

ibis.postgres table expressions dont recognize macaddr datatype #2461

esamuel1 opened this issue Oct 12, 2020 · 1 comment · Fixed by #2464
Labels
feature Features or general enhancements postgres The PostgreSQL backend

Comments

@esamuel1
Copy link

Impacts ibis 1.3.0

Ibis doesn't appear to recognize macaddr data types in postgres when trying to build an ibis table expression. A simple reproduction of the issue is below:

pgcon = ibis.postgres.connect(
    database=database,
    host=host,
    user=user,
    password=password,
    port=port
)

tblnm='mactbl'
mactbl='''
create table if not exists {} (
sometime timestamp,amac macaddr);
'''.format(tblnm)
pgcon.raw_sql(mactbl)
mactblexp=pgcon.table(tblnm)
NotImplementedError: Could not find signature for dtype: <PGDialect_psycopg2, MACADDR>

Looking at the sqlalchemy docs, it seems they do support macaddr for postgres.

@datapythonista datapythonista added postgres The PostgreSQL backend feature Features or general enhancements labels Oct 12, 2020
@datapythonista
Copy link
Contributor

Thanks for the report @esamuel1, I don't think this should be difficult to add. If you want to have a look at the code, and try to submit a pull request, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements postgres The PostgreSQL backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants