Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove coerce_to_dataframe from execute_udaf_node_groupby in pandas backend #2496

Closed
icexelloss opened this issue Oct 26, 2020 · 1 comment
Labels
refactor Issues or PRs related to refactoring the codebase

Comments

@icexelloss
Copy link
Contributor

In #2487, we added a this to execute_udaf_node_groupby to coerce the output to the right shapes when executing struct UDF, however, this is not great because this does similar things to pandas.execution.util.coerce_to_output but we cannot use pandas.execution.util.coerce_to_output because we are in the inner loop. (pandas.execution.util.coerce_to_output only works after getting the result from inner loop).

Would be nice to clean this up and conform to a single coercion function.

@cpcloud cpcloud changed the title Remove coerce_to_dataframe from execute_udaf_node_groupby in pandas backend refactor: remove coerce_to_dataframe from execute_udaf_node_groupby in pandas backend Dec 29, 2021
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Jan 9, 2022
@cpcloud
Copy link
Member

cpcloud commented Jan 10, 2022

PRs welcome! We're trying to keep the issue backlog tidy, so going to close this out. Feel free to submit refactors as PRs directly.

@cpcloud cpcloud closed this as completed Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

No branches or pull requests

2 participants