Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery connect doesn't use project_id if no credentials are passed #2588

Closed
toryhaavik opened this issue Jan 13, 2021 · 0 comments · Fixed by #2652
Closed

bigquery connect doesn't use project_id if no credentials are passed #2588

toryhaavik opened this issue Jan 13, 2021 · 0 comments · Fixed by #2652
Milestone

Comments

@toryhaavik
Copy link
Contributor

ibis.bigquery.connect takes an arg project_id of type Optional[str]=None. It also takes an optional credentials arg. The way the code is written, if no credentials are passed, the user-passed project_id is thrown away in favor of the user's default project. I don't have a BQ account myself, but I think that some logic is needed to check if the user passes an explicit project_id and use that even if they pass None for credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants