-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BigQuery backend to a separate repository #2665
Comments
|
agree on all points here we should extend the docs to point to additional backends but i don't think we should have any testing in the main repo for them (to avoid crazy does) wouldn't object to moving impala / clickhouse but let's do omniscidb and bigquery seem good to me |
|
Agreed.
So long as we have some tests in the BQ repo against the HEAD of the core Ibis library, this sounds good to me. |
|
ibis-project/ibis-bigquery#1 has some initial GitHub Actions setup. I have a few questions about it, but I think it's in at least the same shape as the BigQuery backend is in this repo now. |
|
hey guys, are there any other tasks to complete this move? I guess we will also have to update the docs and so on? so I wouldn't mind helping out to document the changes made |
|
It should still work. It's using entrypoints, so you need to install the bigquery package with pip, like For the documentation, there shouldn't be any change for the user, other than installing the package separately, so not much to document I'd say. But feel free to clarify or add anything you think it makes sense. Documenting the new backend API is something we'll have to do. But still working on it, so not sure what the latest version will look like. |
|
thanks @datapythonista ! I had installed with |
|
The backend has been moved to https://github.com/ibis-project/ibis-bigquery, closing. |
I think it would make sense to move BigQuery (probably more backends, but starting by discussing BigQuery) into a separate repository, in the same way as we did or OmniSciDB in #2356.
I think in the past it probably made sense to have all backends in this same repo. But I think now it makes more sense to try to reduce the number we develop here. Some of the reasons:
The only drawback that I would consider is being able to make changes to both Ibis core and the backends at the same time. I'm working at the moment in having a well specified API for Ibis to communicate with backends. With a proper public API for backends, I think modifying things in both at the same time will become a liability more than an asset. I think any change in Ibis required by a backend should be made first and separate from the changes to the backend code. It'll still take some weeks until we're in this point, but I think it's a good time to start considering moving more backends out. I think BigQuery is a good candidate that should benefit from it, besides Ibis itself.
Thoughts @jreback and @tswast ?
The text was updated successfully, but these errors were encountered: