Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQLAlchemy 1.4 #2689

Closed
datapythonista opened this issue Mar 16, 2021 · 1 comment · Fixed by #2690
Closed

Support SQLAlchemy 1.4 #2689

datapythonista opened this issue Mar 16, 2021 · 1 comment · Fixed by #2690
Labels
ci Continuous Integration issues or PRs compatibility Compatibility related issues or PRs tests Issues or PRs related to tests
Milestone
Next release

Comments

@datapythonista
Copy link
Contributor

datapythonista commented Mar 16, 2021 •
edited
Loading

Looks like sqlalchemy.Binary has been removed in 1.4, released in conda-forge 4 hours ago, and it's breaking Ibis.

There are some other issues in SQLAlchemy, and also, our setup.py requires old versions, and 1.3.7 is not supported.
@datapythonista datapythonista added tests Issues or PRs related to tests ci Continuous Integration issues or PRs compatibility Compatibility related issues or PRs labels Mar 16, 2021
@gerrymanoim
Copy link
Contributor

https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-214869a306f72f33237772d33fc332ec

@datapythonista datapythonista added this to the Next release milestone Mar 16, 2021
This was referenced Mar 16, 2021
Merged
Closed
Closed
@datapythonista datapythonista changed the title SQLAlchemy 1.4 breaking Ibis Support SQLAlchemy 1.4 Mar 16, 2021
@cpcloud cpcloud mentioned this issue Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous Integration issues or PRs compatibility Compatibility related issues or PRs tests Issues or PRs related to tests
Projects
None yet
Milestone
Next release
Development

Successfully merging a pull request may close this issue.

Making Ibis work with SQLAlchemy 1.4
2 participants
@gerrymanoim @datapythonista