Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SQLAchemy backend insert implementation to include usage of table_expr for inserting data #2778

Closed
harsharaj96 opened this issue May 14, 2021 · 2 comments
Labels
feature Features or general enhancements

Comments

@harsharaj96
Copy link
Contributor

Apart from inserting data using a dataframe or by giving a table name, if a user gives table expression as input then insert operation must be performed into the desired table.

@datapythonista
Copy link
Contributor

Not for the current work, but for the future, I think it probably makes more sense to have a single argument source that can be a dataframe, an expression, another table.... and perform the operation based on the type. Instead of having a different argument for each source kind.

harsharaj96 added a commit to harsharaj96/ibis that referenced this issue May 28, 2021
@harsharaj96
Copy link
Contributor Author

Using the obj variable in the .insert() function to take either pandas DataFrame or table_name or ibis TableExpr like what we wanted to do with the source variable. Added test cases for this scenario as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
None yet
Development

No branches or pull requests

2 participants