Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate verify #2865

Closed
datapythonista opened this issue Jul 17, 2021 · 0 comments · Fixed by #2866
Closed

DEPR: Deprecate verify #2865

datapythonista opened this issue Jul 17, 2021 · 0 comments · Fixed by #2866
Labels
internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase
Milestone

Comments

@datapythonista
Copy link
Contributor

We've got a method verify that simply compiles a expression, and returns if the compilation raised an exception. Doesn't seem very useful (users can compile themselves, in the very rare cases this is really needed). The public API is already huge, so removing and simplifying things seems a good idea.

This is what will be deprecated:

ibis.sqlite.verify(expr)
@datapythonista datapythonista added internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase labels Jul 17, 2021
@jreback jreback added this to the Next release milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants