-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: ensure that downstream dependencies remain compatible with ibis 4.x #4519
Comments
|
@jreback @icexelloss @timothydijamco I'm not sure where are you at the migration, but please let me know if I can help you with anything. I created a |
|
Thanks! In term of migration status, we haven't started working on it. It's close to year-end so it's hard to squeeze in a major development effort like the ibis 3 -> 4 migration on our side (most people are busy with finishing up their year-end goal). What are you guys thoughts around: |
|
@icexelloss Thanks for chiming in! The plan is to port nothing back to 3.x for now. Regarding ibis-substrait, how does 3-4 months sound for a cutover to 4.0? In the meantime, I can try to look into adding a shim layer for ibis-substrait that is backwards compatible so that 3.x and 4.x can live alongside each other for that period. After 3-4 months though, we'll set a lower bound to ibis 4. How does that sound? |
|
Sorry for the delayed reply but yeah I think it is reasonable but I cannot promise we will be 100% ready to go with ibis 4.x in 3-4 month time (it depends on how much work is needed for bumping to ibis 4 internally and when we can schedule the work) but I think it's a reasonable target. |
|
Just as a sidenote: the migration may seem like a big effort, but the majority of the incompatibilities can be resolved by removing the |
|
Hopefully..(finger crossed) |
|
What I mean it may worth a try sooner than later. I'll be harder for us too to recall how to resolve the more complicated scenarios. |
|
@kszucs Can we add a |
|
Definitely, that's a pretty good idea actually! Would you mind putting up a PR for it? |
|
Closing this out, the |
We should ensure projects depending on ibis remain functional with all the breaking changes we merged with #4512
Pay attention to:
The text was updated successfully, but these errors were encountered: