regression(mssql): investigate bringing back any/all and cumulative versions
#8073
Closed
1 task done
Assignees
Labels
mssql
The Microsoft SQL Server backend
regression
Issues related to things that used to work but don't anymore
tes-required-for-release
Things that must be addressed before *release* of `main` after merging in `the-epic-split`
Comments
cpcloud
added
mssql
gforsyth
added a commit
that referenced
this issue
Feb 21, 2024
## Description of changes I took a look through what sqlalchemy was generating for these failing test cases and then reimplemented it using sqlglot. Any and All: * Instead of `logical or` we do a `Max(IIF(condition, 1, 0))` * Instead of `logical and` we do a `Min(IIF(condition, 1, 0))` Cumulative versions: The cumulative versions work, but required an additional check in the `visit_Not` node. MSSQL doesn't support doing `IFF(MAX(IFF(...` -- the argument to IFF has to be a boolean and the Window function isn't considered a boolean for some reason, so the outer conditional needs to be a case statement.- fix(mssql): restore any, all and cumulative versions - fix(mssql): support aggregations with any/all ## Issues closed * Resolves #8073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
These are now failing on
the-epic-splitWhat version of ibis are you using?
the-epic-splitWhat backend(s) are you using, if any?
mssql
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: