You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does not pass the parameters to backend._from_url. I would expect location=us-central1 to be passed to the underlying bigquery connection.
I'm not sure if this is intentional, because the ibis.connect function goes to the trouble of parsing the parameters from the connection string but then uses orig_kwargs for
My usecase (and why I don't particularly want to specify location directly) is that I want users to be able to pass any connection string they want through to Ibis from configuration and use this as a means to configure the connection appropriately, subject to me filtering supported backends for my application. I haven't tried parameters with any other of the backends.
This is similar to the sqlalchemy connection string logic mentioned in #2532 (comment).
Any advice on how the general ibis connection strings handle parameters like this for a consistent user experience? I'd be happy to submit a PR for the latter option, it should be quite simple.
The text was updated successfully, but these errors were encountered:
With version 9.0.0 of ibis, passing:
ibis.connect(bigquery://my_project/my_dataset?location=us-central1)Does not pass the parameters to
backend._from_url. I would expectlocation=us-central1to be passed to the underlying bigquery connection.I'm not sure if this is intentional, because the
ibis.connectfunction goes to the trouble of parsing the parameters from the connection string but then usesorig_kwargsforibis/ibis/backends/__init__.py
Line 1394 in 33ec754
Alternatively, it could be solved in a backend specific way for bigquery by parsing out the configuration here:
ibis/ibis/backends/bigquery/__init__.py
Line 335 in 33ec754
My usecase (and why I don't particularly want to specify location directly) is that I want users to be able to pass any connection string they want through to Ibis from configuration and use this as a means to configure the connection appropriately, subject to me filtering supported backends for my application. I haven't tried parameters with any other of the backends.
This is similar to the sqlalchemy connection string logic mentioned in #2532 (comment).
Any advice on how the general ibis connection strings handle parameters like this for a consistent user experience? I'd be happy to submit a PR for the latter option, it should be quite simple.
The text was updated successfully, but these errors were encountered: