-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add day_of_week* API #1047
Add day_of_week* API #1047
Conversation
|
@wesm @jreback Curious about your thoughts on the API here. I've defined
Originally I had |
|
maybe have day_of_week be a node which can have index() or name() in it? |
|
Interesting. This could be modeled as a So for example a user could do the following: dow = t.date_column.day_of_week()
result = dow.execute() # this returns a Series of dict
index = dow.index().execute() # series of int32
name = dow.name().execute() # series of strings |
469d986
to
14e6746
Compare
bc0f04b
to
86fcee5
Compare
e3f59b6
to
eac17c2
Compare
|
Merging on green. |
closes #306