Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allow like operation to accept a list of conditions to match #1061

Closed
wants to merge 1 commit into from
Closed

ENH: Allow like operation to accept a list of conditions to match #1061

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 30, 2017

Closes #1060

@cpcloud cpcloud requested a review from wesm June 30, 2017 21:05
@cpcloud cpcloud self-assigned this Jun 30, 2017
@cpcloud cpcloud added the feature Features or general enhancements label Jun 30, 2017
@cpcloud cpcloud modified the milestones: 0.11.2, 0.11.3 Jun 30, 2017
wesm
wesm reviewed Jul 3, 2017
View reviewed changes
ibis/expr/api.py Outdated
),
util.promote_list(patterns)
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace the fanciness from the map on down with a more vanilla list comprehension?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, for sure

@cpcloud cpcloud closed this in 12d364b Jul 6, 2017
@cpcloud cpcloud deleted the like-patterns branch July 6, 2017 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm left review comments

Assignees

@cpcloud cpcloud

Labels
feature Features or general enhancements
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @wesm