Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Implement comparison for string vs date and timestamp types #1065

Closed
wants to merge 1 commit into from
Closed

ENH: Implement comparison for string vs date and timestamp types #1065

wants to merge 1 commit into from

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 18, 2017

No description provided.

@cpcloud cpcloud added this to the 0.11.3 milestone Jul 18, 2017
@cpcloud cpcloud added the feature Features or general enhancements label Jul 18, 2017
@cpcloud cpcloud self-assigned this Jul 18, 2017
@cpcloud cpcloud force-pushed the fix-temporal-comparison branch 2 times, most recently from 67828ee to 5b86859 Compare July 18, 2017 22:42
@cpcloud
Copy link
Member Author

cpcloud commented Jul 18, 2017

This needs backend tests before merging.

@cpcloud cpcloud force-pushed the fix-temporal-comparison branch 2 times, most recently from 0eaabc4 to e368707 Compare July 19, 2017 20:27
@cpcloud
Copy link
Member Author

cpcloud commented Jul 19, 2017

@wesm can you take a look here when you get a chance?

wesm
wesm approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpcloud cpcloud closed this in 19d6177 Jul 20, 2017
@cpcloud cpcloud deleted the fix-temporal-comparison branch July 20, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees

@cpcloud cpcloud

Labels
feature Features or general enhancements
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @wesm