New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ensure that we only cast if timezone is not None #1147

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@cpcloud
Member

cpcloud commented Aug 28, 2017

No description provided.

@cpcloud cpcloud self-assigned this Aug 28, 2017

@cpcloud cpcloud added this to the 0.11.3 milestone Aug 28, 2017

@cpcloud

This comment has been minimized.

Member

cpcloud commented Aug 28, 2017

Merging on green.

@wesm

wesm approved these changes Aug 28, 2017

@@ -1884,7 +1884,9 @@ def between_time(arg, lower, upper, timezone=None):
"""
if isinstance(arg.op(), _ops.Time):
arg = arg.op().args[0].cast(dt.Timestamp(timezone=timezone))
arg = arg.op().args[0]

This comment has been minimized.

@jreback

jreback Aug 28, 2017

Contributor

maybe a commento about why this is needed here?

This comment has been minimized.

@cpcloud
@cpcloud

This comment has been minimized.

@cpcloud cpcloud closed this in 8173e44 Aug 28, 2017

@cpcloud cpcloud deleted the cpcloud:fix-tz branch Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment