BUG/CLN: Fix predicates on Selections on Joins #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
from
42a5690
to
43961a9
Compare
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
2 times, most recently
from
68d40f1
to
0c3924c
Compare
cpcloud
changed the title
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
from
338ead8
to
36b2355
Compare
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
from
36b2355
to
da6d646
Compare
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
4 times, most recently
from
3bba9a6
to
3daef3f
Compare
cpcloud
changed the title
jreback
reviewed
Oct 14, 2017
| } | ||
|
|
||
|
|
||
| LEFT_JOIN_SUFFIX = '_ibis_left_{}'.format(ibis.util.guid()) |
There was a problem hiding this comment.
should these be functions? so the guid is on demand? (IOW what if you do a join of a join)?
There was a problem hiding this comment.
This isn't an issue because by the time the next join is executed we've removed this suffix. I have some tests for this: test_multi_join_with_post_expression_filter.
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
2 times, most recently
from
b9bb874
to
354582a
Compare
Also refactors the code in the projection execution out into a couple of multipledispatch cases for each kind of projection.
cpcloud
force-pushed
the
fix-selection-join-predicates
branch
from
354582a
to
d76b2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is twofold
execute_selection_dataframefunction because it was getting rather large and unreadable.The bug in #1136 was occurring due to the fact that the predicates in the
Selectionwere not being evaluated against thedataargument which is the result of the joined data. This doesn't fail on non-Joinselections because there's no possible ambiguity regarding which column to select. The solution is to map each root table in each predicate todata, therefore evaluating the predicate against the joined data.Closes #1136.